From b1ca06ca1cbca2a94e09e8b6edd1609da455bd59 Mon Sep 17 00:00:00 2001
From: Marcus Noble <github@marcusnoble.co.uk>
Date: Tue, 7 Dec 2021 10:08:44 +0000
Subject: [PATCH] Improved gs-login

Signed-off-by: Marcus Noble <github@marcusnoble.co.uk>
---
 home/.bin/gs-login | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/home/.bin/gs-login b/home/.bin/gs-login
index db95d41..2930361 100755
--- a/home/.bin/gs-login
+++ b/home/.bin/gs-login
@@ -4,6 +4,7 @@ set -e
 
 TTL="24h"
 CERTIFICATE_GROUP="system:masters"
+DEBUG=""
 
 print_usage() {
   echo "gs-login - login to Giant Swarm managed clusters"
@@ -20,6 +21,8 @@ print_usage() {
   echo "-g, --certificate-group   the certificate group to login as on the workload cluster (default: system:masters)"
 }
 
+POS_ARGS=()
+
 while test $# -gt 0; do
   case "$1" in
     -t|--ttl)
@@ -36,21 +39,29 @@ while test $# -gt 0; do
       print_usage
       exit 0
       ;;
+    --debug)
+      DEBUG="--debug"
+      shift
+    /)
+      # We want to ignore slash seperators between MC and WC
+      shift
+      ;;
     *)
-      break
+      POS_ARGS+=(`echo $1 | tr '/' ' '`)
+      shift
       ;;
   esac
 done
 
-case $# in
+case ${#POS_ARGS[@]} in
   1)
-    kubectl gs login $1 2>/dev/null || opsctl kgs login -i $1
+    kubectl gs login ${POS_ARGS[0]} ${DEBUG} 2>/dev/null || opsctl kgs login -i ${POS_ARGS[0]}
     ;;
   2)
-    kubectl gs login $1 --workload-cluster $2 --certificate-group system:masters --certificate-ttl 24h
+    kubectl gs login ${POS_ARGS[0]} --workload-cluster ${POS_ARGS[1]} --certificate-group ${CERTIFICATE_GROUP} --certificate-ttl ${TTL} ${DEBUG}
     ;;
   3)
-    kubectl gs login $1 --workload-cluster $2 --certificate-group system:masters --certificate-ttl 24h --organization $3
+    kubectl gs login ${POS_ARGS[0]} --workload-cluster ${POS_ARGS[1]} --certificate-group ${CERTIFICATE_GROUP} --certificate-ttl ${TTL} --organization ${POS_ARGS[2]} ${DEBUG}
     ;;
   *)
     print_usage